[
https://issues.apache.org/jira/browse/CASSANDRA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701705#action_12701705
]
Jonathan Ellis commented on CASSANDRA-95:
-----------------------------------------
If we're going to do it "right" shouldn't we have AbstractReadCommand,
ColumnsReadCommand, SliceReadCommand, etc. subclasses instead of faking it w/ a
type attr?
> clean up ReadCommand and related stuff for read repairs
> -------------------------------------------------------
>
> Key: CASSANDRA-95
> URL: https://issues.apache.org/jira/browse/CASSANDRA-95
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue95.patchv1
>
>
> Today, ReadCommand doesn't have an explicit type attribute. A specific type
> of ReadCommand is determined based on subtle difference in parameters set.
> For example:
> if (start > 0 || (count > 0 && count < Integer.MAX_VALUE))
> {
> return table.getRow(key, columnFamilyColumn, start, count);
> }
> A get_slice ReadCommand is determined based on start and count values. This
> is very hard to understand. Also, code like that is duplicated in ReadCommand
> and ConsistencyManager.
> We need to make it easier to determine the type of a ReadCommand. This is
> necessary for code maintenance as well as supporting new APIs in the future.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
