[
https://issues.apache.org/jira/browse/CASSANDRA-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702588#action_12702588
]
Jonathan Ellis edited comment on CASSANDRA-95 at 4/24/09 3:43 PM:
------------------------------------------------------------------
18 files changed, 728 insertions(+), 585 deletions(-)
of course lines of code isn't everything but it's a bad sign when cleanup
increases the refactored code count by 1/3 instead of decreasing it.
to some degree java is all about the boilerplate but is there anything we can
do about this? i admit that I have no suggestions.
was (Author: jbellis):
18 files changed, 728 insertions(+), 585 deletions(-)
of course lines of code isn't everything but it's a bad sign when cleanup
increases the refactored code count by 50% instead of decreasing it.
to some degree java is all about the boilerplate but is there anything we can
do about this? i admit that I have no suggestions.
> clean up ReadCommand and related stuff for read repairs
> -------------------------------------------------------
>
> Key: CASSANDRA-95
> URL: https://issues.apache.org/jira/browse/CASSANDRA-95
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue95.patchv1, issue95.patchv2
>
>
> Today, ReadCommand doesn't have an explicit type attribute. A specific type
> of ReadCommand is determined based on subtle difference in parameters set.
> For example:
> if (start > 0 || (count > 0 && count < Integer.MAX_VALUE))
> {
> return table.getRow(key, columnFamilyColumn, start, count);
> }
> A get_slice ReadCommand is determined based on start and count values. This
> is very hard to understand. Also, code like that is duplicated in ReadCommand
> and ConsistencyManager.
> We need to make it easier to determine the type of a ReadCommand. This is
> necessary for code maintenance as well as supporting new APIs in the future.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
