[
https://issues.apache.org/jira/browse/CASSANDRA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710458#action_12710458
]
Jonathan Ellis commented on CASSANDRA-172:
------------------------------------------
Okay, that makes sense, although I repeat my suggestion to call these
ColumnGroups, not blocks. I think seek-per-group is reasonable to avoid the
pain of creating a second CF to order in reverse, so +1 for descending
functionalty.
The more I think about the CF wrapper though the more I think you don't need
it. Just update the CF tombstones as you collect iterators from the CFs, and
use addColumn as I suggested. This will also fix the bug where you don't
update tombstones at all if there are no columns found.
Style notes:
prefer while (true) {} to do { } while (true); both loop infinitely but the
first you don't have to skip to the bottom to see what the loop condition is.
prefer declaring variables close to where they are used (e.g. IColumn retColumn
in the iterator code); the more limited the scope of a var is, the easier it is
to see what it's used for.
> A improved and more general version of get_slice
> ------------------------------------------------
>
> Key: CASSANDRA-172
> URL: https://issues.apache.org/jira/browse/CASSANDRA-172
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.4
>
> Attachments: get_slice_from.patchv1, get_slice_from.patchv2
>
>
> Today, get_slice has to scan through all columns in every memtable and
> sstable to get a slice of columns. This becomes inefficient when the number
> of columns in a row is large. We need a more efficient API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
