[ 
https://issues.apache.org/jira/browse/CASSANDRA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711230#action_12711230
 ] 

Jonathan Ellis commented on CASSANDRA-172:
------------------------------------------

Good catch.  I think we can fix that by changing the liveColumns update to

                    IColumn oldColumn = returnCF.getColumn(column.name());
                    // increment "live" count (the one that will be seen by the 
client) if we either
                    // (a) add a live column for the first time, or (b) replace 
a tombstone column w/ a live one.
                    if (!column.isMarkedForDelete() 
                        && (oldColumn == null || (oldColumn.isMarkedForDelete() 
&& column.timestamp() >= oldColumn.timestamp())))
                    {
                        liveColumns++;
                    }

better?

> A improved and more general version of get_slice
> ------------------------------------------------
>
>                 Key: CASSANDRA-172
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-172
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.4
>
>         Attachments: 172-addendum-SF.patch, 172-addendum.patch, 
> get_slice_from.patchv1, get_slice_from.patchv2, get_slice_from.patchv3
>
>
> Today, get_slice has to scan through all columns in every memtable and 
> sstable to get a slice of columns. This becomes inefficient when the number 
> of columns in a row is large. We need a more efficient API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to