[ 
https://issues.apache.org/jira/browse/CASSANDRA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731673#action_12731673
 ] 

Michael Greene commented on CASSANDRA-276:
------------------------------------------

Appear to be fixed in 0002-Cassandra-276-no-WS-Diff.patch:
  There's a bunch of trailing whitespace fixes which should be fixed in the 
final patches that get committed, as discussed on IRC.
  SSTable diff'd incorrectly - did you actually change something in here?


SequenceFile has an odd shoutout: +// HELLO

getColumnFamilyFromFileName can now be easily implemented using split, which is 
preferred in Sun's javadoc.

Can you wrap the debug logging in if (logger_.isDebugEnabled())?

Passes all unit tests, system tests, and my meager local test suite.

> use subdirectory-per-table for data files
> -----------------------------------------
>
>                 Key: CASSANDRA-276
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-276
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Arin Sarkissian
>         Attachments: 0001-Single-pacth-for-Cassandra-276.patch, 
> 0002-Cassandra-276-no-WS-Diff.patch
>
>
> it's a little silly to do this in the filename when the FS will give us a 
> heirarchical structure for free.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to