[
https://issues.apache.org/jira/browse/CASSANDRA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737824#action_12737824
]
Jonathan Ellis commented on CASSANDRA-330:
------------------------------------------
Thanks, will fix those.
I'm not sure what compression would look like for us, since we're not really
Block-based like BT.
But, if we need to add a new abstraction above BufferedRAF, it can only make
that easier to have gotten rid of the old, broken-ass one first. (And however
compression ends up working, trying to cram both log and sstable writers into
the same api is not going to be the way to do it.)
> encapsulate SequenceFile, AbstractWriter better
> -----------------------------------------------
>
> Key: CASSANDRA-330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-330
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-330.txt,
> 0002-move-next-getColumnGroupReader-out-of-SSTableReader.txt,
> 0003-r-m-SF.next-DataOutput-in-favor-of-more-efficient-Ite.txt,
> 0004-r-m-special-case-that-no-column-names-all-columns-add.txt,
> 0005-r-m-code-in-SF.next-handling-being-called-multiple-tim.txt,
> 0006-SF-shouldn-t-duplicate-position-checking-that-was-alre.txt,
> 0007-replace-SF.next-with-code-in-NamesIterator-that-doesn.txt,
> 0008-r-m-SequenceFile.-ColumnGroupReader-moved-to-SSTableSl.txt,
> 0009-remove-AbstractWriter.-all-it-was-providing-was-append.txt
>
>
> these two are just massive piles of encapsulation violation, duplicating code
> from CF/SC/C serializers that make it very error prone to change
> serialization format.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
