[
https://issues.apache.org/jira/browse/CASSANDRA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738080#action_12738080
]
Hudson commented on CASSANDRA-330:
----------------------------------
Integrated in Cassandra #155 (See
[http://hudson.zones.apache.org/hudson/job/Cassandra/155/])
fix spelling, indents from old SequenceFile code
patch by jbellis; reviewed by Stu Hood for
remove AbstractWriter. all it was providing was append methods, which are
inlined into SSTableWriter now; the rest was all wrappers. also, rename some
variables in SST/SSTW.
patch by jbellis; reviewed by Stu Hood for
r/m SequenceFile. ColumnGroupReader moved to SSTableSliceIterator mostly
unchanged for now. (finish cleaning this up in #332)
patch by jbellis; reviewed by Stu Hood for
replace SF.next with code in NamesIterator that doesn't rewrite data through an
extra layer of DataOutput/Input
patch by jbellis; reviewed by Stu Hood for
SF shouldn't duplicate position checking that was already done by SSTable.
move utility methods to IndexHelper. fix off-by-4 in dataSizeReturned.
patch by jbellis; reviewed by Stu Hood for
r/m code in SF.next handling being called multiple times, since it can only be
called once.
patch by jbellis; reviewed by Stu Hood for
r/m special case that no column names=all columns; add test for no-columns
cases.
patch by jbellis; reviewed by Stu Hood for
r/m SF.next(DataOutput) in favor of more-efficient IteratingRow.
patch by jbellis; reviewed by Stu Hood for
move next, getColumnGroupReader out of SSTableReader.
patch by jbellis; reviewed by Stu Hood for
make CommitLog use a raw BufferedRandomAccessFile instead of overloading
AbstractWriter/IFileReader unnecessarily. the set of AW features used by both
CommitLog and SSTable was nil.
patch by jbellis; reviewed by Stu Hood for
> encapsulate SequenceFile, AbstractWriter better
> -----------------------------------------------
>
> Key: CASSANDRA-330
> URL: https://issues.apache.org/jira/browse/CASSANDRA-330
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 0001-CASSANDRA-330.txt,
> 0002-move-next-getColumnGroupReader-out-of-SSTableReader.txt,
> 0003-r-m-SF.next-DataOutput-in-favor-of-more-efficient-Ite.txt,
> 0004-r-m-special-case-that-no-column-names-all-columns-add.txt,
> 0005-r-m-code-in-SF.next-handling-being-called-multiple-tim.txt,
> 0006-SF-shouldn-t-duplicate-position-checking-that-was-alre.txt,
> 0007-replace-SF.next-with-code-in-NamesIterator-that-doesn.txt,
> 0008-r-m-SequenceFile.-ColumnGroupReader-moved-to-SSTableSl.txt,
> 0009-remove-AbstractWriter.-all-it-was-providing-was-append.txt
>
>
> these two are just massive piles of encapsulation violation, duplicating code
> from CF/SC/C serializers that make it very error prone to change
> serialization format.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
