[
https://issues.apache.org/jira/browse/CASSANDRA-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739896#action_12739896
]
Jun Rao commented on CASSANDRA-332:
-----------------------------------
Comments:
1. IndexHelper.IndexInfo: it's not clear to me why both firstName and LastName
are needed.
2. In SSTableNamesIterator, after calling IndexHelper.IndexFor(), it seems that
you need to check if the index is out of range (in particular, when index ==
indexList.size())
3. In TableTest.testGetSliceFromLarge(), now that you made the value smaller,
you probably need to increase the number of columns inserted to make sure
multiple column index entries are created.
> Clean up SSTableSliceIterator to not echo data around DataOutput/Inputs
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-332
> URL: https://issues.apache.org/jira/browse/CASSANDRA-332
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments:
> 0001-CASSANDRA-332-add-test-for-multi-block-reversal.txt,
> 0002-don-t-serialize-unused-column-count-into-column-index.txt,
> 0003-always-write-indexes-for-at-least-first-and-last-colum.txt,
> 0004-move-comparator-out-of-IndexInfo.txt,
> 0005-avoid-copying-variables-to-ColumnGroupReader-that-it-c.txt,
> 0006-final-cleanup-of-SSTableSliceIterator-now-with-less-u.txt
>
>
> use CFSerializer.deserializeEmpty and then read the columns as necessary,
> similar to what was done for SSTableNamesIterator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
