[ 
https://issues.apache.org/jira/browse/CASSANDRA-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740027#action_12740027
 ] 

Jonathan Ellis commented on CASSANDRA-332:
------------------------------------------

1) that relates to this         // TODO push finishColumn down here too, so we 
can tell when we're done and optimize away the slice when the index + 
start/stop shows there's nothing to scan for

the check will look something like

if (finish < indexes[0].firstcolumn || start > indexes[-1].lastcolumn)

+ the special casing of ascending of course.

2) my understanding is that the java binary search will never yield index == 
indexList.size().  or did you mean something else?

3) ok, will fix

> Clean up SSTableSliceIterator to not echo data around DataOutput/Inputs
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-332
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-332
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 
> 0001-CASSANDRA-332-add-test-for-multi-block-reversal.txt, 
> 0002-don-t-serialize-unused-column-count-into-column-index.txt, 
> 0003-always-write-indexes-for-at-least-first-and-last-colum.txt, 
> 0004-move-comparator-out-of-IndexInfo.txt, 
> 0005-avoid-copying-variables-to-ColumnGroupReader-that-it-c.txt, 
> 0006-final-cleanup-of-SSTableSliceIterator-now-with-less-u.txt
>
>
> use CFSerializer.deserializeEmpty and then read the columns as necessary, 
> similar to what was done for SSTableNamesIterator

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to