[
https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740938#action_12740938
]
Jonathan Ellis commented on CASSANDRA-311:
------------------------------------------
the system tests are not updated, but they pass, which in this case means the
patch is broken since the system (thrift) tests _should_ need to be updated.
a quick look shows one example
- reverseOrder = !((SliceFromReadCommand)command).isAscending;
+ reverseOrder = !((SliceFromReadCommand)command).reversed;
where the variable has been renamed but correctness has not been preserved.
since unit tests are passing that may mean there are other errors cancelling
each other out. :)
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch,
> cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite
> possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
