[
https://issues.apache.org/jira/browse/CASSANDRA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741004#action_12741004
]
Bill de hOra commented on CASSANDRA-311:
----------------------------------------
{quote}the system (thrift) tests _should_ need to be updated. {quote}
In test_server.py
_verify_super_range
_verify_super
TestMutations.test_empty_slice_super
TestMutations.test_super_cf_remove_column
TestMutations.test_super_cf_remove_supercolumn
use a boolean for Cassandra.get_slice_super/6 and
_verify_batch
_verify_simple
_verify_range
TestMutations.test_empty_slice
TestMutations.test_cf_remove_column
TestMutations.test_cf_remove
TestMutations.test_super_cf_remove_supercolumn
use a boolean for Cassandra.get_slice/6
Since all that's happen wrt thrift is a renaming a boolean, I wouldn't expect
these to fail.
{quote}
- reverseOrder = !((SliceFromReadCommand)command).isAscending;
+ reverseOrder = !((SliceFromReadCommand)command).reversed;
where the variable has been renamed but correctness has not been preserved.
{quote}
Works fine as it still a boolean assignment inside a method (albeit exposing
fields like that is ugly). All the patches to date indicate this is a signature
rename op. In case there's more to the ticket can you explain what you mean by
correctness?
> replace`isAscending` bool with `reversed`
> -----------------------------------------
>
> Key: CASSANDRA-311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-311
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: cassandra-311-v1.patch, cassandra-311-v2.patch,
> cassandra-311-v3.diff, CASSANDRA-311-v4.diff, CASSANDRA-311-v5.patch
>
>
> reversed is more generic -- now that we allow custom comparators, it's quite
> possible that a user-provided comparator would be descending by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
