[
https://issues.apache.org/jira/browse/CASSANDRA-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Zlatanov updated CASSANDRA-764:
-----------------------------------
Attachment: 004-CASSANDRA-764-moretests.patch
With 004, this passes all tests, including bitmask ranges, by forcing a row
cache flush at the time of a ColumnFamilyStore::forceFlush()
I don't know if forcing the row cache to be flushed is required. I know that
when the bitmask tests run, the row cache contains an empty column family when
the column family should contain several columns. Forcing a cache flush
fetches the right values. I don't know, however, whether the problem that
causes that invalid cached value is with the bitmasks patch or if it already
existed (maybe linked to the IdentityQueryFilter that the row cache uses, or to
the memtable switch). So I really need some advice here if this is not the
right approach.
Minor stuff: I introduced a getMethodName() in TableTest so the test row key is
linked to the test that's run. I think it makes sense to use that system in
the other TableTest unit tests as well, but I didn't make the change in case
that change is not welcome. Similarly I think assertColumns() should print the
column names as assertBitmaskedColumns() does.
> bitmasks applied to SliceRange
> ------------------------------
>
> Key: CASSANDRA-764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-764
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Priority: Minor
> Attachments: 001-CASSANDRA-764-bitmasksparameter.patch,
> 002-CASSANDRA-764-bitmaskserialization.patch,
> 002-CASSANDRA-764-bitmaskserialization.patch,
> 002-CASSANDRA-764-bitmaskserialization.patch,
> 003-CASSANDRA-764-bitmasktests.patch, 004-CASSANDRA-764-moretests.patch,
> 004-CASSANDRA-764-moretests.patch
>
>
> Add bitmasks (OR of an array of ANDs) to the SliceRange. Make them optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
