[
https://issues.apache.org/jira/browse/CASSANDRA-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833939#action_12833939
]
Jonathan Ellis commented on CASSANDRA-764:
------------------------------------------
Here are comments on patch 01. If they are applicable, please apply to the
other patches too.
01: still adds TODO about method not being used, that is
>>> new ArrayList<byte[]>(0)
use Collections.emptyList
>>> null == reference
use reference == null
>>> hasFullPredicate
don't make a method for something trivial. and isn't this backwards, i.e.,
shouldn't it return true if bitmasks is NOT null?
>>> int limit = Math.min(bitmask.length, name.length)
ISTM that the semantics for a bitmask predicate against a value of a different
length are unclear. Let's stick to only matching values of the same length.
>>> for (int i=0; i < bitmasks.size(); i++)
use a foreach loop
>>> PredicateUtils
prefer google collections to apache commons unless the former does not support
what you need (here you want Predicates.or)
> bitmasks applied to SliceRange
> ------------------------------
>
> Key: CASSANDRA-764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-764
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Assignee: Ted Zlatanov
> Priority: Minor
> Attachments: 001-CASSANDRA-764-bitmasksparameter.patch,
> 002-CASSANDRA-764-bitmaskserialization.patch,
> 002-CASSANDRA-764-bitmaskserialization.patch,
> 002-CASSANDRA-764-bitmaskserialization.patch,
> 003-CASSANDRA-764-bitmasktests.patch, 004-CASSANDRA-764-moretests.patch,
> 004-CASSANDRA-764-moretests.patch
>
>
> Add bitmasks (OR of an array of ANDs) to the SliceRange. Make them optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
