[
https://issues.apache.org/jira/browse/CASSANDRA-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838519#action_12838519
]
Jonathan Ellis commented on CASSANDRA-764:
------------------------------------------
Comments:
0. patch to Memtable needs rebasing, it did not apply
1. In
if (bitmasks != null && !bitmasks.isEmpty()) return
Predicates.or(getBitmaskMatchColumnPredicate())
the .or is redundant, is it not?
2. Still lots of null != reference
3. Re "it returns false now [on different byte[] length]," matchesBitmaskString
still only compares up to the min length. (and matchesBitmask would be a
better name, wouldn't it? there are no Strings involved here)
4.
+// Collection<IColumn> columns = cf == null ? new TreeSet<IColumn>() :
cf.getSortedColumns();
+// List<String> L = new ArrayList<String>();
let's not commit commented-out code, please.
5.
+ String getMethodName()
Just hardcode a row name, this is more obfuscatory than helpful.
6.
+ assert Arrays.equals(la, columnNames)
+ : "Columns [" + ((cf == null) ? "" :
cf.getComparator().getColumnsString(columns)) + "(as string: " + lasb.t
+ + " is not expected [" + StringUtils.join(columnNames, ",")
+ "] (bitmasks " + SliceFromReadCommand.getBit
please use String.format for monsters like this :)
> bitmasks applied to SliceRange
> ------------------------------
>
> Key: CASSANDRA-764
> URL: https://issues.apache.org/jira/browse/CASSANDRA-764
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Ted Zlatanov
> Assignee: Ted Zlatanov
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 001-CASSANDRA-754-bitmasks.patch
>
>
> Add bitmasks (OR of an array of ANDs) to the SliceRange. Make them optional.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
