[ 
https://issues.apache.org/jira/browse/CASSANDRA-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840813#action_12840813
 ] 

Jonathan Ellis commented on CASSANDRA-764:
------------------------------------------

+    public static boolean matchesBitmask(byte[] bitmask, byte[] name)
+    {
+        if (name == null || bitmask == null || bitmask.length != name.length) 
return false;

don't use " == null checks" for never-supposed-to-happen conditions.  use 
asserts.

put the stmt part of "if (cond) stmt" on a separate line from the if, there's a 
lot of those here.

other than that, +1.

> bitmasks applied to SliceRange
> ------------------------------
>
>                 Key: CASSANDRA-764
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-764
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Ted Zlatanov
>            Assignee: Ted Zlatanov
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: 0001-CASSANDRA-764-bitmasks.patch
>
>
> Add bitmasks (OR of an array of ANDs) to the SliceRange.  Make them optional.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to