An updated patch would be great. Would you also mind using tabs instead of spaces as that's the Castle coding convention.
Thanks On Tue, Feb 10, 2009 at 12:32 AM, Craig Vermeer <[email protected]> wrote: > Hi Jonathan, > > The SomeString property doesn't really serve any purpose. I had originally > thought of populating it in the default constructor and testing that it was > populated, but decided that it wasn't necessary. > > And re: the other GetConstructor call in the method, no, there was no > particular reason for skipping it. I guess I just missed it in favor of the > public default constructor case, which was what I needed. > > Re: the delay, no problem. I just figured that people weren't checking the > moderator queue to approve new members, so I entered a ticket in the support > site as well. > > If you like, I'm happy to create a new patch that addresses the other > GetConstructor call in the method as well, and attach it to that ticket. > > Thanks, > Craig > > > On Sun, Feb 8, 2009 at 10:21 PM, Jonathon Rossi <[email protected]>wrote: > >> Thanks Craig. I have just a few questions before I apply the patch. >> >> What is the SomeString property in ClassWithDefaultConstructor for the >> unit test? >> >> Also is there a reason you chose not to change the other GetConstructor >> call a few lines down, so that it works for non-public instance >> constructors? >> >> >> On Fri, Feb 6, 2009 at 4:22 AM, Craig Vermeer <[email protected]> wrote: >> >>> Hello all, >>> >>> It appears that generating a Class Proxy does not generate a default >>> constructor on the proxied object, because of the Binding Flags that are >>> used in the GetConstructor call within GenerateParameterlessConstructor in >>> BaseProxyGenerator.cs. >>> >>> Christ Ortman submitted a patch for this back in May 2007, but it looks >>> like that patch was rolled back a month or so later along with a bunch of >>> other changes. Here's a link to Chris' patch: >>> >>> >>> http://groups.google.com/group/castle-project-devel/browse_thread/thread/13cbe659a108b12b/b50a3cf857c1243a >>> >>> In case the rollback was a mistake, attached is a new patch (with a test) >>> with essentially the same fix. >>> >>> Thanks, >>> Craig Vermeer >>> >>> >>> >> >> >> -- >> Jono >> >> >> > > > > -- Jono --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
