> One thing I noticed while reading the changes, is that your ReSharper must > be configured to put a space before method parameters (both actual and > formal). I am about to commit some formatting changes including fixing > those. It reminds me of the mono project's coding style. > > ValidateMixinInterfaces (interfaceType.GetInterfaces (), > roleOfCheckedInterface);
Yeah, you are right, that's our company's coding style. I'll have to configure ReSharper not to insert them for the Castle solutions. Fabian > On Sat, Apr 25, 2009 at 1:12 AM, Fabian Schmied <[email protected]> > wrote: >> >> > Do you think you will have any more changes to commit for this? I'll >> > take a >> > look at your commit, but I doubt you would have missed anything :) >> >> This should be finished, I think. If you find that I've missed >> anything, please let me know. >> >> Fabian >> >> > On Fri, Apr 24, 2009 at 8:14 PM, Fabian Schmied >> > <[email protected]> >> > wrote: >> >> >> >> > I'm late to the discussion, but I agree that allowing the simple case >> >> > and >> >> > throwing on an ambiguous case is the best idea at the point. >> >> >> >> Done (r5624). This proved to be much more involved than I thought, >> >> since there are so many possibilities. (Target class, target >> >> interface, additional interfaces...) >> >> I hope I've missed none of them. >> >> >> >> Fabian >> >> >> >> >> > >> > >> > >> > -- >> > Jono >> > >> > > >> > >> >> > > > > -- > Jono > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
