I took a peak at the patch. Seems very promising! But I agree with Roelof, big changes should happen in small steps.
Thanks On Mon, Jun 8, 2009 at 11:37 AM, Roelof Blom<[email protected]> wrote: > Henrik, > > I've seen your patch and was quite overwhelmed by the sheer amount of > changes, pPerhaps you should start by explaining what your patch is supposed > to do; you sent a 4000+ line patch file out of the blue stating > 'AutomaticTransactionManagement needs to be updated with a bit of code > [...]'. Start a discussion to gain feedback, supply a small code spike, try > to gather interest for your feature on the list and/or UserVoice. > > A sample spec like this > http://using.castleproject.org/display/AR/NHEventListenerSpecs would also be > a good thing for such a complex feature you are proposing. > > -- Roelof. > > > > On Mon, Jun 8, 2009 at 7:46 PM, Henrik Feldt <[email protected]> wrote: >> >> However, considering I can’t commit nor get anyone answering my e-mails >> about this (the patch I sent + testing it out), how am I supposed to get >> somewhere with this? If I’m supposedly in charge of the transaction project, >> surely I could have access to that specific part of the trunk or otherwise >> have someone actually commit my changes? >> >> >> >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Henrik Feldt >> Sent: den 31 maj 2009 15:22 >> To: [email protected] >> Subject: RE: Castle Transactions >> >> >> >> Man, you’re great to have when I hadn’t slept for way too long! J >> >> >> >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Roelof Blom >> Sent: den 31 maj 2009 07:52 >> To: [email protected] >> Subject: Re: Castle Transactions >> >> >> >> Check Environment.OSVersion.Platform? >> >> On Sun, May 31, 2009 at 2:00 AM, Henrik Feldt <[email protected]> wrote: >> >> If there is something similar for Mono, that would be great, because we >> wouldn’t need platform-specific compiles… >> >> >> >> Regards, >> >> Henrik >> >> >> >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Roelof Blom >> Sent: den 30 maj 2009 23:51 >> >> To: [email protected] >> Subject: Re: Castle Transactions >> >> >> >> You need to check at runtime, don't you? Use something like this >> >> if(Environment.OSVersion.Version.Major > 5) { /* vista and above */ } >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> On Sun, May 31, 2009 at 12:16 AM, Henrik Feldt <[email protected]> wrote: >> >> Actually, no, because it’s built on the vista kernel and hence supports >> TxF and TxR, but I’m not sure what to do about Win5 and lesser. Is there >> some sort of compile-constant for it? This is the way it currently looks, >> and I think I need something pre-vista and not just MONO: >> >> >> >> Example: >> >> /// <summary> >> >> /// Deletes a folder recursively. >> >> /// </summary> >> >> /// <param name="path"></param> >> >> public void Delete(string path) >> >> { >> >> AssertAllowed(path); >> >> #if !MONO >> >> IFileTransaction tx; >> >> if (HasTransaction(out tx)) >> >> { >> >> ((IDirectoryAdapter)tx).Delete(path); >> >> return; >> >> } >> >> #endif >> >> Directory.Delete(path); >> >> } >> >> >> >> >> >> >> >> >> >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Roelof Blom >> Sent: den 30 maj 2009 20:15 >> >> To: [email protected] >> Subject: Re: Castle Transactions >> >> >> >> Non-Vista would also be Windows 7 RC? >> >> On Sat, May 30, 2009 at 9:03 PM, Henrik Feldt <[email protected]> wrote: >> >> Cool, np. I’ve changed it. Quite ready to commit now. I guess it’s >> patching that’s it for me, right… >> >> >> >> I need someone to test on non-vista systems and mono to make sure the new >> code paths don’t become activated. Volunteers? >> >> >> >> Cheers, >> >> Henke >> >> >> >> From: [email protected] >> [mailto:[email protected]] On Behalf Of Jonathon Rossi >> Sent: den 30 maj 2009 16:18 >> To: [email protected] >> Subject: Re: Castle Transactions >> >> >> >> Shouldn't it be using Castle's ILogger in Castle.Core, which indirectly >> can depend on log4net. >> >> On Sat, May 30, 2009 at 8:34 PM, Henrik Feldt <[email protected]> wrote: >> >> Can we make it depend on log4net? >> >> >> >> >> >> >> -- >> Jono >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> > > > > > -- Cheers, hammett http://hammett.castleproject.org/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Development List" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en -~----------~----~----~----~------~----~------~--~---
