After you patched the tests still pass?

On Wed, Sep 24, 2008 at 8:57 AM, James Curran <[EMAIL PROTECTED]> wrote:
>
> On Sep 23, 5:11 pm, James Curran <[EMAIL PROTECTED]> wrote:
>> On Sep 23, 4:20 pm, hammett <[EMAIL PROTECTED]> wrote:
>>
>> > Trunk version? Really?!
>>
>> Probably not the absolute latest, but to should be less than a month
>> old.  (I'll update when I get home)
>
> To update on the original problem.  I was running the truck from early
> July (I download & build regularly, but forget to copy it to my
> website bin directory).
> But even with the latest, the same problems exist.  So, I started
> single-stepping through the code, to see where things go awry.
>
> First problem:  I had, 'new PatternRoute("troupebyname", "/Troupe/
> <name>.rails") '  but it wants to be 'new PatternRoute("troupebyname",
> "/Troupe/
> [name].rails")'.  That's probably a bug in the code, as in other
> places it accepts either character, but at one spot, it only accepts
> "[".
>
> But, that didn't solve the problem, so I continued further.  What I
> found as in /trunk/Components/Binder/Castle.Components.Binder/
> DefaultConverter.cs at about line 33, we have:
>        else if (inputType == desiredType)
>        {
>                exactMatch = true;
>        }
>
> when what we actually want is:
>        else if (inputType == desiredType)
>        {
>                exactMatch = true;
>               return true;
>        }
>
> Which bring up the question... Why isn't that bring the whole system
> down?
>
> (I created a patch for that, but since it's just a one-liner someone
> may want to just fix it directly)
> >
>



-- 
Cheers,
hammett
http://hammett.castleproject.org/

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Castle Project Users" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/castle-project-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to