Hi Sudhi/Keith,

I don't want to hurt anyone feelings but want to bring few things to your
notice:

While debugging the problem, I noticed that the Marshal.java class contains
2090 lines of code. Even if you leave aside blank lines and comments, that a
lot of code for a single class. 

The marshal(Object object, XMLFieldDescriptor descriptor, DocumentHandler
handler) method alone contains 817 lines of code. Agreed, it is well
document and etc. But I must admit that you need a cycle of code refactoring
to get it under control.

Also, I noticed that most of the code in the above method is iterative
rather than recursive. Sometime, recursive is simpler.

Suggestions don't help you earn bread, do they? I am willing to spend some
time refactoring if you are ready for it.

Enjoy weekend!
Kiran



----------------------------------------------------------- 
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
        unsubscribe castor-user

Reply via email to