Hi guys,
Kiran, you're right...it does need some refactoring and it is a big class! I have it my castor notebook of things I need to do for a while now. We need to do this one in "baby-steps" though, too many changes at once usually leads to errors. You're certainly welcome to help on this, if you do, please contact me directly and we can try and coordinate this because if the diff file is too big I can assure you I'm not going to have fun trying to review it! :-) --Keith Sudhendra Seshachala wrote: > > Keith is the best person to answer this. > > -----Original Message----- > From: Gawde, Kiran [mailto:[EMAIL PROTECTED] > Sent: Friday, June 18, 2004 5:13 PM > To: '[EMAIL PROTECTED]' > Subject: Re: [castor-user] [XML] Marshall attribute > > Hi Sudhi/Keith, > > I don't want to hurt anyone feelings but want to bring few things to > your > notice: > > While debugging the problem, I noticed that the Marshal.java class > contains > 2090 lines of code. Even if you leave aside blank lines and comments, > that a > lot of code for a single class. > > The marshal(Object object, XMLFieldDescriptor descriptor, > DocumentHandler > handler) method alone contains 817 lines of code. Agreed, it is well > document and etc. But I must admit that you need a cycle of code > refactoring > to get it under control. > > Also, I noticed that most of the code in the above method is iterative > rather than recursive. Sometime, recursive is simpler. > > Suggestions don't help you earn bread, do they? I am willing to spend > some > time refactoring if you are ready for it. > > Enjoy weekend! > Kiran > > ----------------------------------------------------------- > If you wish to unsubscribe from this mailing, send mail to > [EMAIL PROTECTED] with a subject of: > unsubscribe castor-user > > ------------------------------------------------------------------------ > ----------------------------------------------------------- > If you wish to unsubscribe from this mailing, send mail to > [EMAIL PROTECTED] with a subject of: > unsubscribe castor-user ----------------------------------------------------------- If you wish to unsubscribe from this mailing, send mail to [EMAIL PROTECTED] with a subject of: unsubscribe castor-user
