Hi, I like it very much. I think it adds great value for ccache, and to my old memcached-only attempt.
I did not realize the use for moxi also as a connection "keep-alive" mechanism, and a way to hide the syn-ack latency overhead. I think this is what you mean by "avoid some of the network overhead." .This perhaps would deserve a little bit more details in the doc. Even if it is not ready, I think it would be worth to create a pull request, and make it easier for everybody to review the current code. This is what I used to do it, but its not easy to put and track review comments. https://github.com/jrosdahl/ccache/compare/master...itensionanders:memcached-only Mike already put a bunch of coding style review comments on my own commits. I would rather not fix them myself, as I know you already have an evolved version which is more suitable for merging. Cheers Pierre Le ven. 4 déc. 2015 à 22:45, Anders Björklund <and...@itension.se> a écrit : > > The option to switch the to_cache/from_cache can be made available > > separately, like it was in your PR. But it can use another config ? > > Probably needs some updating and refactoring, and it would be nice > > to try and keep the code duplication between them to a minimum... > > > > i.e. between the current filesystem code and the memcached code > > > > I can make an attempt to merge them, or if you want to do it... > > To add a config like "memcached_only", next to "memcached_conf" ? > > If you have a single server, then *neither* option makes any sense. > > So it all depends on the setup, and needs to benchmarked further... > > Here is such an attempt, to keep *both* features available: > https://github.com/itensionanders/ccache/tree/memcached-only > > If you set memcached_only to true, it will not use the fs cache. > Currently it will store the manifests locally, as in the original. > > Also added a basic unit test to it. > > Needs some cleanup, but works OK ? > > /Anders > _______________________________________________ > ccache mailing list > email@example.com > https://lists.samba.org/mailman/listinfo/ccache > _______________________________________________ ccache mailing list firstname.lastname@example.org https://lists.samba.org/mailman/listinfo/ccache