On 07/08/15 23:37, Douglas Carmichael wrote: > To whom it may concern: > > I have finally patched the two problem source files in dtmail to enable CDE > to successfully compile with the libiconv port on FreeBSD 10. > (While libiconv replaces the system iconv, it is needed for glib which is > used by many other FreeBSD ports.) > > Should this patch be committed as-is, or do you see any problems with it?
Hello, the problem with the patch is that it only works if libiconv is installed. If not the build of CDE fails. But libiconv is deprecated since FreeBSD 10 because the iconv functions have been moved to libc. So this patch helps for some systems which have libiconv installed as a dependency but it damages the other FreeBSD systems. What we need is a patch which works in both cases, with and without libiconv. And we also have to make sure that the patch works on FreeBSD 9 and older. Best Regards, Ulrich ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ cdesktopenv-devel mailing list cdesktopenv-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
