On Sat, 11 Jul 2015, Ulrich Wilkens wrote:
> On 07/08/15 23:37, Douglas Carmichael wrote:
> > To whom it may concern:
> >
> > I have finally patched the two problem source files in dtmail to enable CDE
> > to successfully compile with the libiconv port on FreeBSD 10.
> > (While libiconv replaces the system iconv, it is needed for glib which is
> > used by many other FreeBSD ports.)
> >
> > Should this patch be committed as-is, or do you see any problems with it?
>
> Hello,
>
> the problem with the patch is that it only works if libiconv is
> installed. If not the build of CDE fails.
> But libiconv is deprecated since FreeBSD 10 because the iconv functions
> have been moved to libc.
There are two issues - whether libiconv is there or not (I am not sure
since when we have iconv support in base - maybe it's in 8.4 too?)
Another issue is whether we have
size_t
iconv(iconv_t cd, char ** restrict src, size_t * restrict srcleft,
char ** restrict dst, size_t * restrict dstleft);
or is it
size_t
iconv(iconv_t cd, const char ** restrict src, size_t * restrict srcleft,
char ** restrict dst, size_t * restrict dstleft);
See:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199099
That's why I proposed _FreeBSD_version test for that.
~Marcin
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
