On 06/27/18 01:46, Jon Trulson wrote:
On 06/26/2018 05:35 PM, Ulrich Wilkens wrote:
On 06/27/18 00:29, Jon Trulson wrote:
The link imports/x11/include/Xm can be removed. It's not needed
anymore. But the link imports/x11/include/X11 is still needed by
BSDs and Suns. Its removal might be something for later.
I have removed these links for both X11 and Motif on BSD (>= 6.x
only) and FreeBSD (>= 11.x only) and they build fine without
them...
Well, I've just tested it again. You are right that OpenBSD 6 and
FreeBSD 11 don't need it. But the older definitely need it. And
NetBSD also needs it independent from the version.
Sorry, just to be clear:
When you tested it again, did you remove the OS version checks around
UseInstalledX11 in OpenBSD.cf and FreeBSD.cf? If you didn't, then the
failures you mention would be expected, since the "magic" isn't enabled
for those older ones.
No, I just tested the current master without the X11 link.
(And I was not even aware of this checks)
But ok, I will check again this night without the checks.
Hmm, NetBSD.cf doesn't has UseInstalledX11 - so I will add it.
But even if the test succeeds, we will need an additional patch
to remove the X11 link.
I am just having difficulty understanding why it should fail on those
systems, unless the X11 and Motif headers are located in some strange
place that the build doesn't know about.
Maybe I should locate a FreeBSD 10.x system to play with too.
I think the better way is to get rid of makedepend. Then we can also
remove
the X11 link.
Can we?
Can we what? get rid of makedepend or remove the link afterwards?
If you mean the first one: It works for gcc, you've already proved it
for Linux. For clang I've seen some hints on stackoverflow, so it should
work. SunCC could be a problem, must be examined.
And by the way, this removal isn't a code change. It's just a
description
in the wiki.
Please explain - I don't understand this part...
Well, the links are not created by CDE code. They have to be created
manually
as a precondition and that's described in the wiki. So if you want to remove
them just remove it from the description.
Of course the code must support it.
[...]
No problem. :) Thanks for checking them. Also, you had mentioned in
an earlier post that my changes regarding warnings on the BSD's might
break things... I am guessing they didn't?
Of course they do. GCC support is broken at the moment for FreeBSD and
OpenBSD.
But I have a patch in preparation. I was just running out of time due to
my VM problems.
:( Sorry about that. I did test with GCC6 on fbsd and that worked ok.
On OpenBSD, I always use the standard clang that's installed, so I never
tried GCC on those.
-jon
[...]
--
Ulrich Wilkens
Email: m...@uwilkens.de
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
