Dear all, Rajarshi, Christoph, and I to make an extension of the patch reviewing policy.
In general it works fine, any most patches are reviewed, code is improved, and things are fine. Every now and then, an patch does not get reviewed within reasonable time, which is annoying to both the CDK patch gatekeeper (Rajarshi and me) as well as the submitter. For example, patch "MDLWriter should report details on the IO setting(s) - ID: 3029445" [0] is such one. It was submitted in July, and has not seen any review yet. To overcome this problem, we decided to tune the reviewing process as follows. The reviewing process is important and does improve the overall code quality of the CDK. If time permits, I will write up some statistics on the process at some point. Patches that do not get reviewed in three months, get automatically approved, given: * one week before that time an email gets send to the cdk-user@ mailing list by anyone to indicate the deadline has been almost reached * a comment must be left in the patch tracker making people aware of this email * if within that time no one responds, the patch gets applied * the patch gatekeeper decides on the appropriate branch (development or stable) Of course, everyone is more than welcome to encourage others to review patches before that last week! Then, after one week, the patch is automatically accepted. It is the responsibility of the patch gatekeeper to do a quick check, possibly rebase, etc, to do some work to make it applicable. No such email has been send around right now, but that will likely happen. Egon 0.http://sourceforge.net/tracker/?func=detail&aid=3029445&group_id=20024&atid=320024 -- Dr E.L. Willighagen Postdoctoral Research Associate University of Cambridge Homepage: http://egonw.github.com/ LinkedIn: http://se.linkedin.com/in/egonw Blog: http://chem-bla-ics.blogspot.com/ PubList: http://www.citeulike.org/user/egonw/tag/papers ------------------------------------------------------------------------------ What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d _______________________________________________ Cdk-user mailing list Cdk-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdk-user
