Hi sage , I will add two configure options to --with-librocksdb-static and --with-librocksdb , with --with-librocksdb-static option , ceph will compile the code that get from ceph repository , with --with-librocksdb option , in case of distro packages for rocksdb , ceph will not compile the rocksdb code , will use pre-installed library. is that ok for you ?
since current rocksdb does not support autoconf&automake , I will add autoconf&automake support for rocksdb , but before that , i think we should fork a stable branch (maybe 3.0) for ceph . -----Original Message----- From: Mark Nelson [mailto:[email protected]] Sent: Wednesday, May 21, 2014 9:06 PM To: Shu, Xinxin; Sage Weil Cc: [email protected]; Zhang, Jian Subject: Re: [RFC] add rocksdb support On 05/21/2014 07:54 AM, Shu, Xinxin wrote: > Hi, sage > > I will add rocksdb submodule into the makefile , currently we want to have > fully performance tests on key-value db backend , both leveldb and rocksdb. > Then optimize on rocksdb performance. I'm definitely interested in any performance tests you do here. Last winter I started doing some fairly high level tests on raw leveldb/hyperleveldb/raikleveldb. I'm very interested in what you see with rocksdb as a backend. > > -----Original Message----- > From: Sage Weil [mailto:[email protected]] > Sent: Wednesday, May 21, 2014 9:19 AM > To: Shu, Xinxin > Cc: [email protected] > Subject: Re: [RFC] add rocksdb support > > Hi Xinxin, > > I've pushed an updated wip-rocksdb to github/liewegas/ceph.git that includes > the latest set of patches with the groundwork and your rocksdb patch. There > is also a commit that adds rocksdb as a git submodule. I'm thinking that, > since there aren't any distro packages for rocksdb at this point, this is > going to be the easiest way to make this usable for people. > > If you can wire the submodule into the makefile, we can merge this in so that > rocksdb support is in the ceph.com packages on ceph.com. I suspect that the > distros will prefer to turns this off in favor of separate shared libs, but > they can do this at their option if/when they include rocksdb in the distro. > I think the key is just to have both --with-librockdb and > --with-librocksdb-static (or similar) options so that you can either use the > static or dynamically linked one. > > Has your group done further testing with rocksdb? Anything interesting to > share? > > Thanks! > sage > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" > in the body of a message to [email protected] More majordomo > info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
