On Mon, 8 Dec 2014, Matt W. Benjamin wrote:
> Hi devs,
> 
> We've created a new branch wip-claim-2, and new pull request 
> https://github.com/linuxbox2/linuxbox-ceph/pull/3
> based on review feedback.
> 
> The big change is to replace "volatile" with "sharable", and replace 
> "strong_claim()" with "clone_nonsharable()."
> This may not be perfect, feedback appreciated.  It does remove the 
> overloading of "claim()", which people found
> confusing.

I made a few comments, but overall it looks okay to me.  Can you make the 
next pull request against the github.com/ceph/ceph repo instead of your 
clone?

        https://github.com/ceph/ceph/compare

Thanks!
sage

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to