Pushed wip-claim-3, which makes the changes you requested in IRC, plus adds a unittest block.
Matt ----- "Sage Weil" <[email protected]> wrote: > On Mon, 8 Dec 2014, Matt W. Benjamin wrote: > > Hi devs, > > > > We've created a new branch wip-claim-2, and new pull request > https://github.com/linuxbox2/linuxbox-ceph/pull/3 > > based on review feedback. > > > > The big change is to replace "volatile" with "sharable", and replace > "strong_claim()" with "clone_nonsharable()." > > This may not be perfect, feedback appreciated. It does remove the > overloading of "claim()", which people found > > confusing. > > I made a few comments, but overall it looks okay to me. Can you make > the > next pull request against the github.com/ceph/ceph repo instead of > your > clone? > > https://github.com/ceph/ceph/compare > > Thanks! > sage -- Matt Benjamin CohortFS, LLC. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://cohortfs.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
