On 07/11/2019 05:34 AM, Edward Kalk wrote:
> The Docs say : http://docs.ceph.com/docs/nautilus/rbd/iscsi-targets/
> 
>   * Red Hat Enterprise Linux/CentOS 7.5 (or newer); Linux kernel v4.16
>     (or newer)
> 
> ^^Is there a version combination of CEPH and Ubuntu that works? Is
> anyone running iSCSI on Ubuntu ?
> -Ed
> 

There is still one rpm dep left. See attached hack patch.

We just need to make that kernel check generic and not use the rpm
labelCompare call. For RH/tcmu-runner based distros we do not need a
specific kernel version check plus the distro version check.
tcmu-runner/target_core_user should return an error if something is not
supported if the kernel is not supported.

Ricardo,

For SUSE/target_core_rbd, I think we just need to add a check for if
target_core_rbd is available, right? Maybe we want a backstore specific
callout/check?
diff --git a/rbd-target-api.py b/rbd-target-api.py
index 690a045..8dce0e8 100755
--- a/rbd-target-api.py
+++ b/rbd-target-api.py
@@ -16,7 +16,6 @@ import inspect
 import copy
 
 from functools import (reduce, wraps)
-from rpm import labelCompare
 import rados
 import rbd
 
@@ -2637,19 +2636,6 @@ def pre_reqs_errors():
     else:
         errors_found.append("OS is unsupported")
 
-    # check the running kernel is OK (required kernel has patches to rbd.ko)
-    os_info = os.uname()
-    this_arch = os_info[-1]
-    this_kernel = os_info[2].replace(".{}".format(this_arch), '')
-    this_ver, this_rel = this_kernel.split('-', 1)
-
-    # use labelCompare from the rpm module to handle the comparison
-    if labelCompare(('1', this_ver, this_rel), ('1', k_vers, k_rel)) < 0:
-        logger.error("Kernel version check failed")
-        errors_found.append("Kernel version too old - {}-{} "
-                            "or above needed".format(k_vers,
-                                                     k_rel))
-
     return errors_found
 
 
_______________________________________________
ceph-users mailing list
ceph-users@lists.ceph.com
http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com

Reply via email to