Dear @JonathanGregory,

I think this is really good :+1:

I especially like that this description has a strong focus on describing the 
mapping between the tuple of `year, month, day, hour, minute, second` and 
`coordinate value` as it is currently handled in practice. In my opinion, 
exactly this description is the most important missing part regarding the 
handling of leap seconds in the current CF Conventions and thus exactly to the 
point of this issue.

#148 may require a rewrite of the 60 second rule into calendar specific 
assumptions, but at this point, I am pretty sure that this can be done without 
contradicting the rule as written in your post (the simplest would be to just 
copy the paragraph into all existing calenders and replace it by other wordings 
for new calendars). However, I think this rewrite should **not** be done 
**now**.

I'd probably have a few more comments on the exact wording, but these are minor 
and I think it is easier to do it within a PR review than in an 
issue-message-stream. Do you agree?

All the best,
Tobi

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://urldefense.us/v3/__https://github.com/cf-convention/cf-conventions/issues/313*issuecomment-795534870__;Iw!!G2kpM7uM-TzIFchu!nDhOqeq3UYUqYQRam6kPt5nOC6851dlJCnV_ve99MjaKvViG83V31Eqn6_q0dZF79RTKoIikbMU$
 
This list forwards relevant notifications from Github.  It is distinct from 
[email protected], although if you do nothing, a subscription to the 
UCAR list will result in a subscription to this list.
To unsubscribe from this list only, send a message to 
[email protected].

Reply via email to