At this point I'm just being nit-picky..... Personally, I wouldn't default anything that's environment specific (in this case: server, username, password). You're going to have manage that somewhere, so why not manage it as part of the Application.cfm (or wherever your global settings happen) and leave the component to be generally reusable (especially if you intend to submit to CFCZone)?
One other minor thing -- turn your list of servers coming in via the argument to init() into an array (listToArray makes this very easy) -- the list lookup via listGetAt is less efficient than array access in your loop (given how short the list is, this is more a style thing, but an easy thing to do). Hopefully someone who know more about LDAP will comment on the general applicability of your code. At first glance, I would expect a general-purpose component to offer more of the LDAP actions, perhaps. > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Behalf Of Dawson, Michael > Sent: Sunday, August 10, 2003 9:26 AM > To: [EMAIL PROTECTED] > Subject: Active Directory Query Service was: RE: [CFCDev] Component > Critique Wanted > > > Here is my almost-ready-for-production cut of the component. I'm pretty > satisfied with this code. I have enough flexibility with the methods, > yet still retain many default values, in the init() method, that I don't > normally touch. > > I do have to give a lot of thanks to the "power contributors" of this > list. I have learned quite a bit about CFCs and OOP (as it applies to > CFMX) from lurking here. > > Is this of the caliber to post on the cfczone or cflib sites? I haven't > seen too many, if any, functions that handle LDAP queries. Do all udfs > on cflib need to be built with cfscript only or will they also accept > tag-based udfs? > > Thanks ---------------------------------------------------------- You are subscribed to cfcdev. To unsubscribe, send an email to [EMAIL PROTECTED] with the word 'unsubscribe cfcdev' in the message of the email. CFCDev is run by CFCZone (www.cfczone.org) and supported by Mindtool, Corporation (www.mindtool.com).
