1. Point taken. 2. Changed from list to array even tho I probably won't see a difference in performance. But, it does look better.
3. CFLDAP is pretty picky about which attribute combinations you use. That's why this particular method is for query-only use. If I were to modify ldap attributes, or modify a dn, I'd have to use a different combination of CFLDAP attributes. I can't specify themin a "catch-all" method because you can't leave some CFLDAP attributes blank even if you don't need to use them. I've written some one-time-use utility pages in CF to clean up our Active Directory. I haven't yet seen a use to put those methods in a production-use component. My next method for this component would be to take some multi-value attributes and parse them from a delimited string into an array or query object. -----Original Message----- From: Nathan Dintenfass [mailto:[EMAIL PROTECTED] Sent: Sunday, August 10, 2003 12:29 PM To: [EMAIL PROTECTED] Subject: RE: Active Directory Query Service was: RE: [CFCDev] Component Critique Wanted At this point I'm just being nit-picky..... Personally, I wouldn't default anything that's environment specific (in this case: server, username, password). You're going to have manage that somewhere, so why not manage it as part of the Application.cfm (or wherever your global settings happen) and leave the component to be generally reusable (especially if you intend to submit to CFCZone)? One other minor thing -- turn your list of servers coming in via the argument to init() into an array (listToArray makes this very easy) -- the list lookup via listGetAt is less efficient than array access in your loop (given how short the list is, this is more a style thing, but an easy thing to do). Hopefully someone who know more about LDAP will comment on the general applicability of your code. At first glance, I would expect a general-purpose component to offer more of the LDAP actions, perhaps. ---------------------------------------------------------- You are subscribed to cfcdev. To unsubscribe, send an email to [EMAIL PROTECTED] with the word 'unsubscribe cfcdev' in the message of the email. CFCDev is run by CFCZone (www.cfczone.org) and supported by Mindtool, Corporation (www.mindtool.com).
