On 8/14/14, 9:43 PM, Dan Albert wrote:
I think I may have misled you when I said we should #ifdef the differences
between glibc and Mac. If there are legitimate differences, we should #ifdef
them. If glibc is wrong (it looks like it often is), we should just XFAIL the
test and file a bug against glibc (or does that data come from an OS package?).
I'm with Dan on this... It seems like these 'fixes' are just lowering the
expectations of tests when testing against a GLIBC system. It's perfectly
appropriate to XFAIL them and let them fail if that is the case.
If you're concerned about test coverage being lower because though there are
lots of assertions in a single test file, it only takes one failure to
effectively hide the results of the others, then I think it makes more sense to
find a way to split the test. That way the part that is XFAIL'd is a bit more
minimal.
Cheers,
Jon
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
--
Jon Roelofs
[email protected]
CodeSourcery / Mentor Embedded
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
