On Thu, Aug 21, 2014 at 7:10 PM, Jacques Pienaar <[email protected]> wrote: > It is to make the interface a bit easier. The dynamic matcher is at runtime > where we don't have access to the constants. So the string conversion allows > referring to attributes via a name instead of raw the enum value.
Ahh, okay, so this is basically a hard requirement. Ew (in the case of attributes). Those enum names are subject to change on a whim. When the enum changes, it's trivial to find breakages because the compiler will tell you immediately. With the dynamic matchers, that won't be the case. Hopefully that's a non-issue. :-) Can we implement getAttrKind as a private API within ArgTypeTraits instead of making it a public API in Basic? ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
