Re: [PATCH] CFE Knob for: Add a thread-model knob for lowering atomics on baremetal & single threaded systems

[David Majnemer]

================
Comment at: lib/CodeGen/BackendUtil.cpp:422-429
@@ -421,1 +421,10 @@
 
+  if (CodeGenOpts.ThreadModel == "posix")
+    Options.ThreadModel = llvm::ThreadModel::POSIX;
+  else if (CodeGenOpts.ThreadModel == "single")
+    Options.ThreadModel = llvm::ThreadModel::Single;
+  else {
+    assert(false && "Invalid Thread model!");
+    Options.ThreadModel = llvm::ThreadModel::POSIX;
+  }
+
----------------
You may want to consider using LLVM's [[ 
http://llvm.org/docs/doxygen/html/classllvm_1_1StringSwitch.html#details | 
StringSwitch ]] here.

================
Comment at: lib/CodeGen/BackendUtil.cpp:427
@@ +426,3 @@
+  else {
+    assert(false && "Invalid Thread model!");
+    Options.ThreadModel = llvm::ThreadModel::POSIX;
----------------
This assertion doesn't look too useful.

http://reviews.llvm.org/D4985



_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits