On 9/3/14, 9:04 AM, Renato Golin wrote:
================
Comment at: lib/CodeGen/BackendUtil.cpp:431
@@ +430,3 @@
+      .Case("posix", llvm::ThreadModel::POSIX)
+      .Case("single", llvm::ThreadModel::Single);
+
----------------
Shouldn't this have a .Default()? If so, which value?
From earlier in the thread:

"I considered it, but Stringswitch wouldn't let me assert that every case was handled."

"StringSwitch does that automatically for you when getting the result
if you leave off the .Default call."


Jon

http://reviews.llvm.org/D4985



--
Jon Roelofs
[email protected]
CodeSourcery / Mentor Embedded
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to