================
Comment at: include/support/newlib/xlocale.h:27
@@ +26,3 @@
+// duck under that velvet rope.
+int isascii(int c);
+
----------------
jfb wrote:
> jroelofs wrote:
> > jfb wrote:
> > > `isascii` ins't in C++11 either :-)
> > > 
> > > Should libc++ not use it at all, or use a special `__isascii`?
> > Not using it would mean lots of ugly newlib specific stuff in locale.cpp 
> > and __locale. Sounds like `inline int __isascii(int c) { int isascii(int); 
> > return isascii(c); }` is the way to go here.
> Would you just leave __isascii in this header? Or fix the rest of libc++ and 
> move it to a global header? That'll be tricky because at least glibc has 
> `#define __isascii(c)`.
Oh. Yucky. __libcpp_isascii it is then....

http://reviews.llvm.org/D5385



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to