================ Comment at: include/__locale:44 @@ +43,3 @@ + return isascii(c); +} + ---------------- jfb wrote: > Could you add a comment explaining this? > > Also, it relies on the C library actually exporting `isascii`, which it would > as long as it has non-strict extensions. I think it's a fair assumption, but > still worth pointing out. > > Shouldn't the forward declaration be `extern "C"`? If it's found at link time > and not in a header then the current code won't work. Humph. I'm not sure I can `extern "C"` the inner declaration. I think I have to give that linkage to the whole thing.
================ Comment at: include/support/newlib/xlocale.h:30 @@ +29,3 @@ + return isascii(c); +} + ---------------- jfb wrote: > Remove. oops ================ Comment at: include/support/newlib/xlocale.h:62 @@ +61,3 @@ + +// Share implementaiton with android bionic +#include <support/xlocale/xlocale.h> ---------------- jfb wrote: > Typo still there. oops http://reviews.llvm.org/D5385 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
