Hi, The explanation for using posix sounds reasonable to me. Windows users can add win32 as an option later if they need it.
================ Comment at: lib/Driver/Driver.cpp:662-663 @@ +661,4 @@ + OS << "Thread model: "; + if (Arg *A = C.getArgs().getLastArg(options::OPT_mthread_model)) + OS << A->getValue(); + else ---------------- Sorry to resurrect a multi-pinged and multi-commented review with another comment, but this would seem to allow "clang -v -mthread-model=silly", wouldn't it? That might be confusing for someone trying to work out what's allowed. http://reviews.llvm.org/D4985 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
