Re: [PATCH] libclang plugin patch

[Stefan Kemnitz]

http://reviews.llvm.org/D5611

Files:
  examples/PrintFunctionNames/CMakeLists.txt
  examples/PrintFunctionNames/PrintFunctionNames.cpp

Index: examples/PrintFunctionNames/CMakeLists.txt
===================================================================
--- examples/PrintFunctionNames/CMakeLists.txt
+++ examples/PrintFunctionNames/CMakeLists.txt
@@ -10,7 +10,7 @@
 endif()
 
 add_llvm_loadable_module(PrintFunctionNames PrintFunctionNames.cpp)
-target_link_libraries( PrintFunctionNames libclang )
+target_link_libraries(PrintFunctionNames libclang)
 
 if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))
   target_link_libraries(PrintFunctionNames ${cmake_2_8_12_PRIVATE}
Index: examples/PrintFunctionNames/PrintFunctionNames.cpp
===================================================================
--- examples/PrintFunctionNames/PrintFunctionNames.cpp
+++ examples/PrintFunctionNames/PrintFunctionNames.cpp
@@ -23,27 +23,25 @@
 
 class PrintFunctionsConsumer : public ASTConsumer {
 public:
-  PrintFunctionsConsumer( const CompilerInstance& _CI ):
-    CI(_CI)
-  {
-    
-  }
-  const CompilerInstance& CI;
+  PrintFunctionsConsumer(const CompilerInstance &_CI) : CI(_CI) {}
+
   virtual bool HandleTopLevelDecl(DeclGroupRef DG) {
-    DiagnosticsEngine& DE = CI.getDiagnostics();
+    DiagnosticsEngine &DE = CI.getDiagnostics();
     for (DeclGroupRef::iterator i = DG.begin(), e = DG.end(); i != e; ++i) {
       const Decl *D = *i;
-      if (const NamedDecl *ND = dyn_cast<NamedDecl>(D)){
+      if (const NamedDecl *ND = dyn_cast<NamedDecl>(D)) {
         llvm::errs() << "top-level-decl: \"" << ND->getNameAsString() << "\"\n";
-	unsigned DiagID = DE.getCustomDiagID(DiagnosticsEngine::Error,
-	    "functions are bad '%0'");
-	DE.Report( ND->getLocStart(), DiagID ) 
-	  << ND->getNameAsString();
+        unsigned DiagID = DE.getCustomDiagID(DiagnosticsEngine::Error,
+                                             "functions are bad '%0'");
+        DE.Report(ND->getLocStart(), DiagID) << ND->getNameAsString();
       }
     }
 
     return true;
   }
+
+private:
+  const CompilerInstance &CI;
 };
 
 class PrintFunctionNamesAction : public PluginASTAction {
@@ -54,7 +52,7 @@
   }
 
   bool ParseArgs(const CompilerInstance &CI,
-                 const std::vector<std::string>& args) {
+                 const std::vector<std::string> &args) {
     for (unsigned i = 0, e = args.size(); i != e; ++i) {
       llvm::errs() << "PrintFunctionNames arg = " << args[i] << "\n";
 
@@ -72,13 +70,11 @@
 
     return true;
   }
-  void PrintHelp(llvm::raw_ostream& ros) {
+  void PrintHelp(llvm::raw_ostream &ros) {
     ros << "Help for PrintFunctionNames plugin goes here\n";
   }
-
 };
-
 }
 
 static FrontendPluginRegistry::Add<PrintFunctionNamesAction>
-X("print-fns", "print function names");
+    X("print-fns", "print function names");

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits