With the nits fixed, it generally looks good from my side. The question is who
the right owner is to give the good to go. Looping in Richard to delegate to
the right person.
================
Comment at: examples/PrintFunctionNames/PrintFunctionNames.cpp:26
@@ -25,1 +25,3 @@
public:
+ PrintFunctionsConsumer(const CompilerInstance &_CI) : CI(_CI) {}
+
----------------
No need for the _. CI(CI) works fine (and does TheRightThing).
================
Comment at: include/clang/Frontend/CompilerInstance.h:713
@@ +712,3 @@
+
+ /// load plugins that were added by -load
+ void loadPlugins();
----------------
Please make comments start with a capital letter.
Also, new doxygen comments should start with \brief
/// \brief Loads plugins that were added by -load.
================
Comment at: lib/Frontend/CompilerInstance.cpp:1626
@@ +1625,3 @@
+CompilerInstance::loadPlugins(){
+ // Load any requested plugins.
+ for (unsigned i = 0, e = getFrontendOpts().Plugins.size(); i != e; ++i) {
----------------
This comment seems superfluous :)
================
Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:182
@@ -181,2 +181,3 @@
// Load any requested plugins.
+ Clang->loadPlugins();
----------------
As does this now.
http://reviews.llvm.org/D5611
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
