It's better. Did you consider other libclang.so's users, c-arcmt-test and libclangTests? I think you may commit them if they would work for you. I don't think they would break anything.
2014-11-05 3:58 GMT+09:00 Rafael Espíndola <[email protected]>: > What about the attached patches adding and using LLVM_BUILD_STATIC? > > > > On 4 November 2014 09:08, NAKAMURA Takumi <[email protected]> wrote: >> Rafael, >> >> I suppose LIBCLANG_BUILD_STATIC is an option to build *extra* libclang.a. >> Then I'd like to use libclang.so regardless of LIBCLANG_BUILD_STATIC. >> FYI, I am enabling LIBCLANG_BUILD_STATIC in my local build tree. >> >> I suggest options; >> >> - Change "libclang and libclang_static" <=> "libclang_shared and >> libclang" according to CMAKE_EXE_LINKER_FLAGS (to scan it). >> - Introduce another option like LLVM_BUILD_STATIC. >> With this, do you think libclang.so could be built with explicit >> target? (like "ninja libclang_shared") >> >> 2014-11-04 0:22 GMT+09:00 Rafael Espíndola <[email protected]>: >>> A build with -static currently fails when trying to link c-index-test. >>> The attached patch fixes it. >>> >>> Cheers, >>> Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
