That patch just needs to update the testcases to reflect that we print
inline asm a regular asm now (see attached patch as an example).

How come you didn't notice the tests failing locally before committing?

On 7 January 2015 at 19:02, Brad Smith <[email protected]> wrote:
> On 01/07/15 11:44, Rafael Espíndola wrote:
>>
>> LGTM
>
>
> Note this is only the Clang side I am going to commit.
> I posted regarding the LLVM backend and keeping the respective
> setting in sync for each respective architecture but haven't
> seen any replies from Eric or Ulrich.
>
>
>> On 5 January 2015 at 19:17, Brad Smith <[email protected]> wrote:
>>>
>>> On Fri, Jan 02, 2015 at 10:33:27PM -0500, Brad Smith wrote:
>>>>
>>>> Use the integrated assembler by default on PowerPC and SPARC.
>>>
>>>
>>> Correct the gcc_forward test that was failing.
>>>
>>> --
>>> This message has been scanned for viruses and
>>> dangerous content by MailScanner, and is
>>> believed to be clean.
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> [email protected]
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>
>>
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
diff --git a/test/CodeGen/PowerPC/asm-constraints.ll b/test/CodeGen/PowerPC/asm-constraints.ll
index f354a8a..97f35dc 100644
--- a/test/CodeGen/PowerPC/asm-constraints.ll
+++ b/test/CodeGen/PowerPC/asm-constraints.ll
@@ -30,10 +30,11 @@ entry:
 }
 
 ; CHECK-LABEL: @foo
-; CHECK: ld [[REG:[0-9]+]],0(4)
-; CHECK-NEXT: cmpw [[REG]],[[REG]]
-; CHECK-NEXT: bne- 1f
-; CHECK-NEXT: 1: isync
+; CHECK: ld [[REG:[0-9]+]], 0(4)
+; CHECK: cmpw 0, [[REG]], [[REG]]
+; CHECK: bne- 0, .Ltmp0
+; CHECK: .Ltmp0:
+; CHECK-NEXT: isync
 
 attributes #0 = { nounwind "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
 attributes #1 = { nounwind }
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to