On 9 January 2015 at 17:13, Brad Smith <[email protected]> wrote: > On 01/07/15 22:13, Rafael Espíndola wrote: >> >> How come you didn't notice the tests failing locally before committing? > > > I didn't run the testsuite as it has been completely broken for awhile > on OpenBSD from a commit from you.
That is no excuse for not running the tests. If you for any reason cannot run the tests you should not commit patches. It would be nice to get the bot fixed. I don't remember it ever being green. > I had been under the assumption it was something local to the machine > but tracked down the commit once I understood what was going on. > > http://lab.llvm.org:8011/builders/clang-amd64-openbsd/builds/6511/steps/check-all/logs/stdio > > This is the commit.. > > https://github.com/llvm-mirror/llvm/commit/6199c0cf17b3c88b67c249b607004806b6df26c3 What is special about LD_PRELOAD on OpenBSD? Cheers, Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
