Hi Charles,
Your patch doesn't handle cases where the alignment is dependent,
getDeclAlign doesn't want to be called in such cases:
template <int N>
struct S {
static int __thread __attribute__((aligned(N))) x;
};
Also, why do you use BaseT->isDependentType() instead of
T->isDependentType()?
On Wed, Apr 1, 2015 at 4:57 PM, Li, Charles <[email protected]
> wrote:
> Hi Clang developers,
>
>
>
> We here at Sony PlayStation have a proposed patch which adds an error
> diagnostic for when TLS variables exceed maximum TLS alignment.
>
> Please note this patch does not affect normal maximum alignments.
>
> This TLS maximum alignment check is currently only turned on for PS4 but
> could potentially be used for other platforms.
>
>
>
> Sincerely,
>
> Charles Li
>
>
>
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
