I have the impression that if there is copy pasted code in a function and there
are warnings then the hash will be the same. I don't know if this would be a
problem.. but is that true?
================
Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:78
@@ -77,2 +77,3 @@
std::string Description;
+ std::string HashField;
PathDiagnosticLocation Location;
----------------
I wonder if this needs to be a std::string.. the size of a hash is known isnt
it.
================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:430
@@ +429,3 @@
+ StringRef HashField, const Decl *D) {
+ static const std::string Delimeter = "$";
+
----------------
It seems to me that this can be a char. Is std::string necessary or was it
chosen for safety?
http://reviews.llvm.org/D10305
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
