Yes, which is probably why this was an if, not a switch (?) On Jun 23, 2015 3:13 AM, "Rafael Espíndola" <[email protected]> wrote:
> there are 37 values and only 2 are used in here :-) > > On 23 June 2015 at 01:22, Nico Weber <[email protected]> wrote: > > I think we prefer listing all enumeration values in switches (iirc > there's > > even some other warning that checks that). > > > > On Jun 22, 2015 9:25 PM, "Douglas Katzman" <[email protected]> wrote: > >> > >> Author: dougk > >> Date: Mon Jun 22 23:20:44 2015 > >> New Revision: 240376 > >> > >> URL: http://llvm.org/viewvc/llvm-project?rev=240376&view=rev > >> Log: > >> Eliminate "enumeration value not handled in switch" warnings > >> > >> (Caused by r240370) > >> > >> Modified: > >> cfe/trunk/lib/Driver/ToolChains.cpp > >> > >> Modified: cfe/trunk/lib/Driver/ToolChains.cpp > >> URL: > >> > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=240376&r1=240375&r2=240376&view=diff > >> > >> > ============================================================================== > >> --- cfe/trunk/lib/Driver/ToolChains.cpp (original) > >> +++ cfe/trunk/lib/Driver/ToolChains.cpp Mon Jun 22 23:20:44 2015 > >> @@ -2455,6 +2455,8 @@ void NaCl_TC::AddClangCXXStdlibIncludeAr > >> llvm::sys::path::append(P, "x86_64-nacl/include/c++/v1"); > >> addSystemInclude(DriverArgs, CC1Args, P.str()); > >> break; > >> + default: > >> + break; > >> } > >> } > >> > >> > >> > >> _______________________________________________ > >> cfe-commits mailing list > >> [email protected] > >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
