Perhaps, but "else if (getThing().getOtherThing() == const)" ... repeated N times sounds like 'switch'. Suggesting to use a syntax about which the compiler won't warn is like the tail wagging the dog.
At any rate, this was patterned after the constructor for NaCl_TC (also in ToolChains) which has the same 3-clause switch plus a default: break, and the symmetry lends to readability. On Tue, Jun 23, 2015 at 8:50 AM, Nico Weber <[email protected]> wrote: > Yes, which is probably why this was an if, not a switch (?) >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
