On Aug 14, 2010, at 2:15 AM, Charles Davis wrote:
> Oops, forgot to attach patch.
> 
> On 8/14/10 3:13 AM, Charles Davis wrote:
>> This patch makes some methods of RecordLayoutBuilder virtual, so they
>> can be overridden for a custom C++ ABI (or possible other purposes).
>> Right now, I don't see any significant differences between the Microsoft
>> and Itanium ABIs, so I haven't added a class for the MS ABI yet.
>> 
>> If you prefer, I can defer this until I really need it.
>> 
>> Chip
> 
> <virtualize-rec-builder.patch>

This seems fine, though yeah, I guess I'd prefer that you checked it in with
the MS layout code.  I'm curious why you needed to override FinishLayout,
though.

John.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to